deprecate downcast functions in favour of cast functions
#5472
+47
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Sep 27, 2025
|
Note to self: I think this probably warrants a migration guide entry (maybe can be written in #5468 and describe both). |
CodSpeed Performance ReportMerging #5472 will not alter performanceComparing Summary
|
Icxolu
approved these changes
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #5468 (comment) this actions the planned deprecation of
.downcast()and similar methods.I reverted their behavioural change in #5387 so that these methods will not change when users upgrade, just be deprecated.
Once they migrate to the
.cast()functions they will then get better ergonmics:DowncastErrorwithCastError#5468).cast_into()without need to have.into_any()first.